FIX: Prevent SDL layouts from being created if a layout already exists#1924
Open
jgcodes2020 wants to merge 3 commits intoUnity-Technologies:developfrom
Open
FIX: Prevent SDL layouts from being created if a layout already exists#1924jgcodes2020 wants to merge 3 commits intoUnity-Technologies:developfrom
jgcodes2020 wants to merge 3 commits intoUnity-Technologies:developfrom
Conversation
|
|
ekcoh
added
the
waiting-for-review
ekcoh
reviewed
Sep 13, 2024
Collaborator
ekcoh
left a comment
ekcoh
left a comment
There was a problem hiding this comment.
Makes sense to prevent layout generation if a matching layout already exists. Thanks for the contribution.
ekcoh
removed
the
waiting-for-review
Collaborator
|
Branch needs to be updated with changes from develop before it may be subject for QA and potential merge. |
Pauliusd01
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unity's HID layout generator does not generate a layout if one already exists. I added this functionality to the Linux/SDL layout generator.
Changes made
Added a check to the SDL layout generator, preventing it from generating a layout if one exists already.
Checklist
Before review:
Changed,Fixed,Addedsections.([case %number%](https://issuetracker.unity3d.com/issues/...)).Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.